Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-1113] feat: Improvement get available CI for station api #56

Merged
merged 6 commits into from
Jun 17, 2024
Merged

[VAS-1113] feat: Improvement get available CI for station api #56

merged 6 commits into from
Jun 17, 2024

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented Jun 17, 2024 •
edited
Loading

List of Changes

  • updated GET /creditorinstitutions/stations/{station-code} API with new parameter ciTaxCodeList. The API search the availables CI for the provided station only among the provided list of CI tax codes
  • fixed H2 schema with missing field in Stazioni entity

Motivation and Context

Improve the performance
VAS#1113

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella added enhancement New feature or request minor Semantic Version: minor change versioning labels Jun 17, 2024
@gioelemella gioelemella requested a review from a team as a code owner June 17, 2024 10:06
@gioelemella gioelemella mentioned this pull request Jun 17, 2024
Merged
5 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jacopocarlini
jacopocarlini approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

@gioelemella gioelemella merged commit 6f1b30b into main Jun 17, 2024
4 checks passed
@gioelemella gioelemella deleted the VAS-1113-improvement-get-available-ci-for-station-api branch June 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

Assignees

@gioelemella gioelemella

Labels
enhancement New feature or request minor Semantic Version: minor change versioning size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gioelemella @jacopocarlini @pagopa-github-bot