Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAGOPA-1751 removing delete of payment types and touchpoints in int t… #143

Merged
merged 1 commit into from
May 15, 2024

Conversation

FedericoRuzzier
Copy link
Contributor

…est batch

List of Changes

Removing delete of touchpoints and payment types in integration test batch

Motivation and Context

Change needed to krrp some important values present in the db

How Has This Been Tested?

Manually with cucumber

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the bug Something isn't working label May 14, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the appropriate action to take is to delete only the items involved in the test cases to prevent test collections from having many unnecessary items.

If this is not needed or if it is not a risk or even if there is already a policy that manages test items -> LGTM 👍

@FedericoRuzzier FedericoRuzzier merged commit bc2d44a into main May 15, 2024
17 checks passed
@FedericoRuzzier FedericoRuzzier deleted the PAGOPA-1751-afm-calculator-fix-int-test branch May 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants