Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAGOPA-1215 afm calculator creare dashboard elk #109

Merged
merged 14 commits into from
Oct 25, 2023

Conversation

jacopocarlini
Copy link
Contributor

@jacopocarlini jacopocarlini commented Oct 2, 2023

List of Changes

New loggingAspect

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jacopocarlini jacopocarlini temporarily deployed to uat October 6, 2023 13:15 — with GitHub Actions Inactive
@jacopocarlini jacopocarlini temporarily deployed to uat October 6, 2023 13:15 — with GitHub Actions Inactive
@jacopocarlini jacopocarlini temporarily deployed to uat October 6, 2023 13:16 — with GitHub Actions Inactive
@jacopocarlini jacopocarlini temporarily deployed to uat October 6, 2023 13:18 — with GitHub Actions Inactive
…are-dashboard-elk # Conflicts: # helm/Chart.yaml # helm/values-dev.yaml # helm/values-prod.yaml # helm/values-uat.yaml # openapi/openapi-node.json # openapi/openapi.json # pom.xml
@jacopocarlini jacopocarlini changed the title Pagopa 1215 afm calculator creare dashboard elk PAGOPA-1215 afm calculator creare dashboard elk Oct 23, 2023
@jacopocarlini jacopocarlini marked this pull request as ready for review October 23, 2023 15:05
@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great , we could use this pr as example to move from AI to ELK logs

@jacopocarlini jacopocarlini merged commit ea9aa58 into main Oct 25, 2023
10 of 11 checks passed
@jacopocarlini jacopocarlini deleted the PAGOPA-1215-afm-calculator-creare-dashboard-elk branch October 25, 2023 09:42
@jacopocarlini jacopocarlini temporarily deployed to dev October 25, 2023 09:44 — with GitHub Actions Inactive
@jacopocarlini jacopocarlini temporarily deployed to dev October 25, 2023 09:45 — with GitHub Actions Inactive
@jacopocarlini jacopocarlini temporarily deployed to dev October 25, 2023 09:50 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants