PIN-5961: added delegation-items-archiver scaffold #1374
Conversation
AsterITA
requested review from
beetlecrunch,
galales,
Carminepo2 and
taglioni-r
as code owners
AsterITA
requested review from
ecamellini,
MalpenZibo and
zerbiniandrea
and removed request for
beetlecrunch,
galales,
Carminepo2 and
taglioni-r
| ? unsafeBrandId<CorrelationId>(delegationMsg.correlation_id) | ||
| : generateId<CorrelationId>(); | ||
|
|
||
| const loggerInstance = logger({ |
There was a problem hiding this comment.
I would move the logger setup in the processMessage main function in the index, so that we set up everything there, before routing from a message to its handler
| // import { getInteropBeClients } from "./clients/clientsProvider.js"; | ||
|
|
||
| // const { agreementProcessClient, purposeProcessClient } = getInteropBeClients(); |
There was a problem hiding this comment.
Same for the clients, let's set them up in the index and pass them as params to handleMessage
There was a problem hiding this comment.
I find the new name less meaningful: delegation archiver seems to be something that archives the delegations, but, instead, it reacts to delegation archive events and archives something else. See for reference eservice-descriptors-archiver: a consumer that reacts to agreements archive events and archives descriptors.
What about something like delegated-agreements-purposes-archiver or delegated-items-archiver or something similar?
I agree with changing its name, how about |
|
@AsterITA |
AsterITA
changed the title
[Closes PIN-5961]