PIN-5884 archivePurposeVersion delegation test #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urposeDelegtionTest
…urposeDelegtionTest
…urposeDelegtionTest
…ivePurposeVersionDelegationTest
…ivePurposeVersionDelegationTest
…ivePurposeVersionDelegationTest
rGregnanin
requested review from
AsterITA,
Carminepo2 and
taglioni-r
as code owners
rGregnanin
requested review from
ecamellini,
sandrotaje,
MalpenZibo and
zerbiniandrea
and removed request for
beetlecrunch,
galales,
Carminepo2 and
taglioni-r
AsterITA
approved these changes
Jan 14, 2025
| @@ -160,6 +177,207 @@ describe("archivePurposeVersion", () => { | |||
|
|
|||
| vi.useRealTimers(); | |||
| }); | |||
| it("should succeed when requester is Consumer Delegate and the Purpose is in a archived state", async () => { | |||
There was a problem hiding this comment.
Suggested change
| it("should succeed when requester is Consumer Delegate and the Purpose is in a archived state", async () => { | |
| it("should write on event-store for the archiving of a purpose version when requester is Consumer Delegate", async () => { |
|
|
||
| vi.useRealTimers(); | ||
| }); | ||
| it("should succeed when requester is Consumer Delegate and the eservice was created by a delegated tenant and the Purpose is in a archived state", async () => { |
There was a problem hiding this comment.
Suggested change
| it("should succeed when requester is Consumer Delegate and the eservice was created by a delegated tenant and the Purpose is in a archived state", async () => { | |
| it("should write on event-store for the archiving of a purpose version when requester is Consumer Delegate and the eservice was created by a delegated tenant", async () => { |
| state: purposeVersionState.active, | ||
| }; | ||
|
|
||
| const delegatePurpose: Purpose = { |
There was a problem hiding this comment.
in order to be a purpose created by the delegate you have to add delegationId
…ivePurposeVersionDelegationTest
…ivePurposeVersionDelegationTest
ecamellini
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Looks good!
You could also add two tests for the following error cases:
- the requester is a delegate for the eservice and is archiving a purpose with no delegationId
- the requester is a delegate for the eservice and is archiving a purpose for a different delegationId (a different delegate)
| const mockPurpose: Purpose = { | ||
| ...getMockPurpose(), | ||
| versions: [mockPurposeVersion], | ||
| consumerId: generateId<TenantId>(), |
There was a problem hiding this comment.
Suggested change
| consumerId: generateId<TenantId>(), | |
| consumerId: authData.organizationId |
| ...getMockPurpose(), | ||
| versions: [mockPurposeVersion], | ||
| consumerId: generateId<TenantId>(), | ||
| delegationId: generateId<DelegationId>(), |
There was a problem hiding this comment.
Suggested change
| delegationId: generateId<DelegationId>(), | |
| delegationId: generateId<DelegationId>(), | |
| consumerId: authData.organizationId |
Base automatically changed from
PIN-5881-UpdatePurposeDelegtionTest
to
feature/incaricato
January 17, 2025 09:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.