-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIN-5883 deletePurpose delegation test #1338
Open
rGregnanin
wants to merge
36
commits into
feature/incaricato
Choose a base branch
from
PIN-5883-DeletePurposeDelegationTest
base: feature/incaricato
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PIN-5883 deletePurpose delegation test #1338
rGregnanin
wants to merge
36
commits into
feature/incaricato
from
PIN-5883-DeletePurposeDelegationTest
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urposeDelegtionTest
…urposeDelegtionTest
…urposeDelegtionTest
…tePurposeDelegationTest
…tePurposeDelegationTest
…tePurposeDelegationTest
rGregnanin
requested review from
AsterITA,
Carminepo2 and
taglioni-r
as code owners
January 10, 2025 16:21
rGregnanin
requested review from
ecamellini,
sandrotaje,
MalpenZibo and
zerbiniandrea
and removed request for
beetlecrunch,
galales,
Carminepo2 and
taglioni-r
January 10, 2025 16:21
AsterITA
approved these changes
Jan 14, 2025
MalpenZibo
approved these changes
Jan 15, 2025
ecamellini
reviewed
Jan 17, 2025
); | ||
}); | ||
|
||
it("should throw organizationIsNotTheConsumer when the requester is the Consumer with no delegation and is deleting a purpose created by a delegate in deletePurpose", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
You could also add two tests for the following error cases:
- the requester is a delegate for the eservice and is deleting a purpose with no delegationId
- the requester is a delegate for the eservice and is deleting a purpose for a different delegationId (a different delegate)
ecamellini
reviewed
Jan 17, 2025
Comment on lines
416
to
421
const mockPurpose: Purpose = { | ||
...getMockPurpose(), | ||
eserviceId: mockEService.id, | ||
versions: [mockPurposeVersion], | ||
delegationId: generateId<DelegationId>(), | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const mockPurpose: Purpose = { | |
...getMockPurpose(), | |
eserviceId: mockEService.id, | |
versions: [mockPurposeVersion], | |
delegationId: generateId<DelegationId>(), | |
}; | |
const mockPurpose: Purpose = { | |
...getMockPurpose(), | |
eserviceId: mockEService.id, | |
versions: [mockPurposeVersion], | |
delegationId: generateId<DelegationId>(), | |
consumerId: authData.organizationId | |
}; |
Base automatically changed from
PIN-5881-UpdatePurposeDelegtionTest
to
feature/incaricato
January 17, 2025 09:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.