Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document first steps and how to setup github actions with Conductor #109

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

pscheit
Copy link
Contributor

@pscheit pscheit commented Dec 13, 2024

No description provided.

@pscheit pscheit requested a review from a team December 13, 2024 14:34
@pscheit pscheit self-assigned this Dec 13, 2024
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 6.6%, saving 12.05 KB.

Filename Before After Improvement Visual comparison
Resources/public/img/docs/conductor/authentication-token.png 74.46 KB 68.93 KB -7.4% View diff
Resources/public/img/docs/conductor/verification-task-list.png 108.28 KB 101.75 KB -6.0% View diff

82 images did not require optimisation.

Copy link
Member

@glaubinix glaubinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is a great start already!

docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
@pscheit pscheit requested a review from glaubinix December 17, 2024 14:18
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
@glaubinix
Copy link
Member

Considering that I fully understand how all this works already. @stevenrombauts do you mind also taking a look at this?

Copy link
Contributor

@stevenrombauts stevenrombauts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These steps are also very clear to me :)

docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
docs/conductor/getting-started.md Outdated Show resolved Hide resolved
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 8.7%, saving 12.16 KB.

Filename Before After Improvement Visual comparison
Resources/public/img/docs/conductor/authentication-token.png 139.71 KB 127.55 KB -8.7% View diff

96 images did not require optimisation.

Copy link
Member

@glaubinix glaubinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a great starting point! One small thing left, rest looks good to me.

docs/conductor/getting-started.md Outdated Show resolved Hide resolved
@pscheit pscheit merged commit 701c922 into main Jan 10, 2025
1 check passed
@pscheit pscheit deleted the conductor-public-docs branch January 10, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants