Add types for SecretWriter & Reader, clean up command line. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding traits for SecretWriters and Readers gives us better structure that will allow us to add new ones. Changes to the command line / clap interface are an attempt to handle the special cases that make assumptions about the state of the YubiHSM more clear / clean.
NOTE: The Cdw type is still unused
flihp
force-pushed
the
secret-reader-writer-factory
branch
from
e3372e0 to
eb0d4a7
Compare
This has me thinking that the Cdw type should be broken up into one that generates Isos and one that does the burning?
|
needs more testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding traits for SecretWriters and Readers gives us better structure that will allow us to add new ones. Changes to the command line / clap interface are an attempt to handle the special cases that make assumptions about the state of the YubiHSM more clear / clean.