Skip to content

Commit

Permalink
Fixup bad comment.
Browse files Browse the repository at this point in the history
Speculating about the origin of this behavior wasn't smart. It's also
probably wrong: RNGs are usually pretty quick, the primality test is
probably a better candidate for blame. Better to stick to the facts.
  • Loading branch information
flihp committed Sep 30, 2024
1 parent eeb2257 commit 50828ae
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/hsm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ pub struct Hsm {

impl Hsm {
// 5 minute to support RSA4K key generation
// NOTE: RSA key generation is very taxing on the PRNG in the YubiHSM.
// It's also highly variable (unpredictable even). In practice we see
// RSA4K keys take anywhere from less than 1 minute to over 4 minutes.
// NOTE: RSA key generation takes a lot of time on the YubiHSM. It's also
// highly viariable: in practice we've seen RSA4K key generation take
// anywhere from less than 1 minute to over 5 minutes.
const TIMEOUT_MS: u64 = 300000;

pub fn new(
Expand Down

0 comments on commit 50828ae

Please sign in to comment.