[ci] Simplify the macOS build #1766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, good to see that the special ffmpeg and sqlite stuff can be removed. Some of the other changes I don't agree with - i.e. not installing bison and flex with the other build tools, removing comments and also removing brew installs of packages that are already installed on the Github runners (that can change in the future + more importantly the workflow is also an install guide for people wanting to build on own machines). I'll make the ffmpeg/sqlite changes in another commit. |
|
Good with me. Keep the spelling of macOS though ;-) |
|
Indeed, fixed that now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to simplify the build process on the newer version of macOS.
It echoes the discussion on the work item #1764.