Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zimbra): open express order tunnel #14958

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(zimbra): open express order tunnel #14958

wants to merge 2 commits into from

Conversation

tristanwagner
Copy link
Contributor

@tristanwagner tristanwagner commented Jan 16, 2025 •
edited
Loading

ref: MANAGER-16753

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-16753
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@tristanwagner
fix(zimbra): various minor ui issues
7ff6591 
ref: MANAGER-16752

Signed-off-by: Tristan WAGNER <[email protected]>
@tristanwagner tristanwagner self-assigned this Jan 16, 2025
@tristanwagner tristanwagner requested review from a team as code owners January 16, 2025 10:48
ghyenne
ghyenne previously approved these changes Jan 16, 2025
View reviewed changes
@tristanwagner
feat(zimbra): open express order tunnel
2f87fc9 
ref: MANAGER-16753

Signed-off-by: Tristan WAGNER <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@tristanwagner
Copy link
Contributor Author

added commit from another PR since they are in conflict, to be removed before merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghyenne ghyenne ghyenne left review comments

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 2 approving reviews are required to merge this pull request.

Assignees

@tristanwagner tristanwagner

Labels
feature New feature translation required universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristanwagner @ghyenne