Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager-react-components): change SMP key to STO for Stockholm #14913

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix(manager-react-components): change SMP key to STO for Stockholm #14913

merged 2 commits into from
Jan 16, 2025

Conversation

fredericvilcot
Copy link
Contributor

Question Answer
Branch? maintenance/manager-react-components-v1.x
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #14909
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@fredericvilcot fredericvilcot requested review from a team as code owners January 14, 2025 15:52
@github-actions github-actions bot added translation required bug Something isn't working labels Jan 14, 2025
@fredericvilcot fredericvilcot linked an issue Jan 14, 2025 that may be closed by this pull request
Wrong key for Stockolm translation #14909
Closed
2 tasks
ppprevost
ppprevost previously approved these changes Jan 14, 2025
View reviewed changes
SimonChaumet
SimonChaumet previously approved these changes Jan 14, 2025
View reviewed changes
anooparveti
anooparveti requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #14911 (review)

@fredericvilcot fredericvilcot force-pushed the fix/mrc-sto-key branch 2 times, most recently from 13b94a9 to 44c77dc Compare January 16, 2025 07:54
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anooparveti anooparveti merged commit 308a529 into maintenance/manager-react-components-v1.x Jan 16, 2025
11 of 14 checks passed
@anooparveti anooparveti deleted the fix/mrc-sto-key branch January 16, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-ciccotti Eric-ciccotti Eric-ciccotti approved these changes

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti

@ppprevost ppprevost Awaiting requested review from ppprevost

@Tsiorifamonjena Tsiorifamonjena Awaiting requested review from Tsiorifamonjena

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong key for Stockolm translation
7 participants
@fredericvilcot @SimonChaumet @ppprevost @Tsiorifamonjena @anooparveti @Eric-ciccotti @reenjii