Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(container): add missing mock for payment modal tests #14887

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(container): add missing mock for payment modal tests #14887

merged 1 commit into from
Jan 13, 2025

Conversation

JacquesLarique
Copy link
Contributor

Question Answer
Branch? release/gcj-w3
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-14722
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated (n/a)
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits (n/a)

Description

Add missing mock for payment modal tests

Related

fix(container): add missing mock for payment modal tests
dcbad72 
ref: MANAGER-14722

Signed-off-by: Jacques Larique <[email protected]>
@JacquesLarique JacquesLarique requested review from a team as code owners January 13, 2025 15:03
@JacquesLarique JacquesLarique requested review from anooparveti, darsene, kqesar and seven-amid and removed request for a team January 13, 2025 15:03
@github-actions github-actions bot added container bug Something isn't working labels Jan 13, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JacquesLarique JacquesLarique merged commit 0977501 into release/gcj-w3 Jan 13, 2025
15 checks passed
@JacquesLarique JacquesLarique deleted the fix/test-modal-payment branch January 13, 2025 16:43
@JacquesLarique JacquesLarique restored the fix/test-modal-payment branch January 14, 2025 10:00
JacquesLarique added a commit that referenced this pull request Jan 14, 2025
@JacquesLarique
Revert "fix(container): add missing mock for payment modal tests (#14887
efafaf6 
)"

This reverts commit 0977501.
@JacquesLarique JacquesLarique mentioned this pull request Jan 14, 2025
Closed
JacquesLarique added a commit that referenced this pull request Jan 14, 2025
@JacquesLarique
Revert "fix(container): add missing mock for payment modal tests (#14887
7f1d0c5 
)"

This reverts commit 0977501.
@JacquesLarique JacquesLarique mentioned this pull request Jan 14, 2025
Merged
JacquesLarique added a commit that referenced this pull request Jan 15, 2025
@JacquesLarique
fix(container): add missing mock for payment modal tests (#14887)
fd66de4 
ref: MANAGER-14722

Signed-off-by: Jacques Larique <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximeBajeux MaximeBajeux MaximeBajeux approved these changes

@aottr aottr aottr approved these changes

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-reactjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-reactjs

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
bug Something isn't working container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacquesLarique @aottr @MaximeBajeux