Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/manager 16660 nutanix error message popin #14841

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix/manager 16660 nutanix error message popin #14841

merged 2 commits into from
Jan 9, 2025

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Jan 9, 2025

Question Answer
Branch? feat/nutanix-scale-in-out
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-16660
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

@tibs245 tibs245 requested a review from a team as a code owner January 9, 2025 08:43
@tibs245 tibs245 requested review from aottr, MaximeBajeux and mhelhali-soufien and removed request for a team January 9, 2025 08:43
@github-actions github-actions bot added universe-hosted-private-cloud bug Something isn't working labels Jan 9, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tibs245 tibs245 merged commit 8370d6d into feat/nutanix-scale-in-out Jan 9, 2025
14 checks passed
@tibs245 tibs245 deleted the fix/MANAGER-16660-nutanix-error-message-popin branch January 9, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vovh vovh vovh approved these changes

@ThibaudCrespin ThibaudCrespin ThibaudCrespin approved these changes

@aottr aottr Awaiting requested review from aottr aottr is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working universe-hosted-private-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tibs245 @ThibaudCrespin @vovh