Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated): add tags column and pop up #14837

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(dedicated): add tags column and pop up #14837

merged 1 commit into from
Jan 9, 2025

Conversation

sachinrameshn
Copy link
Contributor

ref: MANAGER-15572

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15572
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@sachinrameshn sachinrameshn requested a review from a team as a code owner January 8, 2025 15:43
@sachinrameshn sachinrameshn requested review from aottr, MaximeBajeux and oalkabouss and removed request for a team January 8, 2025 15:43
@sachinrameshn
feat(dedicated): add tags column and pop up
99e317e 
ref: MANAGER-15572

Signed-off-by: Sachin Ramesh <[email protected]>
@sachinrameshn sachinrameshn requested a review from qpavy January 9, 2025 09:30
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
22.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sachinrameshn sachinrameshn merged commit 88a8c9c into feat/ovh-tagging Jan 9, 2025
13 of 14 checks passed
@sachinrameshn sachinrameshn deleted the feat/MANAGER-15572 branch January 9, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhelhali-soufien mhelhali-soufien mhelhali-soufien approved these changes

@qpavy qpavy qpavy approved these changes

@aottr aottr Awaiting requested review from aottr aottr is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachinrameshn @qpavy @mhelhali-soufien