Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-office): add license user guides #14810

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat(web-office): add license user guides #14810

merged 1 commit into from
Jan 8, 2025

Conversation

stif59100
Copy link
Contributor

@stif59100 stif59100 commented Jan 7, 2025 •
edited by darsene
Loading

ref:MANAGER-16544

Question Answer
Branch? feat/office365-react-app
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-16544
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

I added guide link for users licenses

Related

@stif59100 stif59100 requested review from a team as code owners January 7, 2025 15:35
@stif59100 stif59100 requested review from tibs245, qpavy, sidlynx, kqesar and darsene and removed request for a team January 7, 2025 15:35
@stif59100 stif59100 force-pushed the feat/MANAGER-16544 branch 3 times, most recently from bbec92a to 1a4eac1 Compare January 7, 2025 16:27
darsene
darsene requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@darsene darsene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest tests are KO

@stif59100 stif59100 force-pushed the feat/office365-react-app branch from f0281bf to 03caf2d Compare January 8, 2025 10:30
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 8, 2025
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jan 8, 2025
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 8, 2025
@stif59100
feat(web-office): add license user guides
bc4640d 
ref:MANAGER-16544

Signed-off-by: stif59100 <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jan 8, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stif59100 stif59100 merged commit 5a85803 into feat/office365-react-app Jan 8, 2025
13 of 14 checks passed
@stif59100 stif59100 deleted the feat/MANAGER-16544 branch January 8, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@ghyenne ghyenne ghyenne approved these changes

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature translation required universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stif59100 @ghyenne @darsene