Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pci ai notebooks unit test listing page #14808

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Feat/pci ai notebooks unit test listing page #14808

merged 3 commits into from
Jan 8, 2025

Conversation

abullet33
Copy link
Contributor

Question Answer
Branch? master / release/** / develop
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@abullet33 abullet33 requested review from a team as code owners January 7, 2025 14:12
@abullet33 abullet33 requested review from JacquesLarique, vovh, kqesar, seven-amid, qpavy and ghyenne and removed request for a team January 7, 2025 14:12
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging translation required feature New feature labels Jan 7, 2025
@abullet33 abullet33 force-pushed the feat/pci-ai-notebooks-unit-test-listing-page branch from b80619d to bb292aa Compare January 7, 2025 14:14
@github-actions github-actions bot removed translation required has conflicts Has conflicts to resolve before merging labels Jan 7, 2025
@abullet33 abullet33 requested a review from jperchoc January 7, 2025 17:18
@abullet33
feat(pci.ai.notebook): add unit test in dashboard page (#14815)
a155fa6 
* feat(pci.ai.notebook): add unit test in dashboard page
* feat(pci.ai.notebook): remove useless comments
REF:DATATR-1819
* feat(pci.ai.notebook): add unit test on logs and backups page (#14832)
REF: DATATR-1823,DATATR-1822
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33 abullet33 merged commit 67c221a into feat/pci-ai-notebooks-epic Jan 8, 2025
10 of 12 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
29.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@abullet33 abullet33 deleted the feat/pci-ai-notebooks-unit-test-listing-page branch January 9, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jperchoc jperchoc jperchoc approved these changes

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@vovh vovh Awaiting requested review from vovh vovh is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abullet33 @jperchoc