Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename service from header #14727

Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat: rename service from header #14727

merged 1 commit into from
Jan 17, 2025

Conversation

jperchoc
Copy link
Contributor

@jperchoc jperchoc commented Dec 26, 2024 •
edited
Loading

ref: DATATR-1540

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #DATATR-1540
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Allow user to rename the database service from the header

@github-actions github-actions bot added the feature New feature label Dec 26, 2024
@jperchoc
feat: rename service from header
1620c9b 
Signed-off-by: Jonathan Perchoc <[email protected]>
@jperchoc jperchoc force-pushed the feat/datatr-1540-rename-service branch from c9be3e4 to 1620c9b Compare December 26, 2024 14:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jperchoc jperchoc marked this pull request as ready for review December 30, 2024 09:26
@jperchoc jperchoc requested review from a team as code owners December 30, 2024 09:26
abullet33
abullet33 previously approved these changes Dec 30, 2024
View reviewed changes
anooparveti
anooparveti previously approved these changes Jan 2, 2025
View reviewed changes
@jperchoc jperchoc changed the base branch from master to develop January 16, 2025 11:03
@jperchoc jperchoc dismissed stale reviews from anooparveti and abullet33 January 16, 2025 11:03

The base branch was changed.

@abullet33 abullet33 self-requested a review January 16, 2025 12:31
@anooparveti anooparveti changed the base branch from develop to release/public-cloud-w4 January 17, 2025 06:56
@anooparveti anooparveti merged commit fdd8553 into release/public-cloud-w4 Jan 17, 2025
27 of 28 checks passed
@anooparveti anooparveti deleted the feat/datatr-1540-rename-service branch January 17, 2025 07:05
@anooparveti anooparveti mentioned this pull request Jan 17, 2025
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abullet33 abullet33 abullet33 approved these changes

@acavalloni acavalloni acavalloni approved these changes

@anooparveti anooparveti anooparveti left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jperchoc @acavalloni @anooparveti @abullet33