feat(pci-gateway): Gateway 3AZ beta #14706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsiorifamonjena
requested review from
frenautvh,
seven-amid,
qpavy,
JacquesLarique and
mhelhali-soufien
github-actions
bot
added
universe-public-cloud
feature
sachinrameshn
previously approved these changes
Dec 24, 2024
packages/manager/apps/pci-gateway/src/pages/add/LocationStep.tsx
Outdated
Show resolved
Hide resolved
oalkabouss
previously approved these changes
Dec 26, 2024
Tsiorifamonjena
dismissed stale reviews from oalkabouss and sachinrameshn
via
3ceef31
Tsiorifamonjena
requested review from
lionel95200x,
sachinrameshn and
oalkabouss
lionel95200x
previously approved these changes
Jan 3, 2025
MaximeBajeux
previously approved these changes
Jan 7, 2025
Tsiorifamonjena
dismissed stale reviews from MaximeBajeux and lionel95200x
via
1e8cb01
github-actions
bot
added
the
dependencies
|
| Name | Status | Previous | Current |
|---|---|---|---|
@ovh-ux/manager-pci-common |
0.14.2 | 0.15.0 |
| if (cloudCatalog) { | ||
| return gatewayRefPlans.map((plan) => { | ||
| const addonHourly = cloudCatalog.addons.find( | ||
| ($addon) => $addon.planCode === plan.code, |
There was a problem hiding this comment.
Why adding $ on params ?
lionel95200x
approved these changes
Jan 15, 2025
MaximeBajeux
approved these changes
Jan 15, 2025
ref: TAPC-2413 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2413 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2413 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2485 Signed-off-by: tsiorifamonjena <[email protected]>
ref-2413 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2306 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2306 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2306 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2306 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2306 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2306 Signed-off-by: tsiorifamonjena <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
Tsiorifamonjena
force-pushed
the
feat/epic-gateway-TAPC-2306
branch
from
6832d2c to
a935985
Compare
|
| @@ -98,21 +99,25 @@ export const LocationStep = () => { | |||
| } | |||
| }, [searchParams, state.regions]); | |||
|
|
|||
| const has3AZ = useMemo(() => isRegionWith3AZ(state.regions), [state.regions]); | |||
|
|
|||
| const pciCommonProperties = usePCICommonContextFactory({ has3AZ }); | |||
There was a problem hiding this comment.
Naming should be agnostic from the library :)
There was a problem hiding this comment.
Since it is the pci common context, how would you name it ?
There was a problem hiding this comment.
Could be directly const meta = usePCICommonContextFactory({ has3AZ }); or something like that ;)
| const { data: cloudCatalog } = useCloudCatalog(); | ||
| const { data: availableGatewayPlans } = useAvailableGatewayPlans(projectId); | ||
|
|
||
| const { data: inactiveRegions } = useInactiveRegions(projectId); | ||
| const getBandWidthLabel = (bandwidth: number) => |
| availableGatewayPlans?.plans.reduce( | ||
| (result: TAvailablePlansGrouped, currentValue: TPlan) => { | ||
| const code = currentValue.code.replace(/\.3AZ$/, ''); | ||
| const newResult = { ...result }; |
There was a problem hiding this comment.
Why not directly returning accumulator?
| const getPrice = (addon: TAddon): number | undefined => | ||
| addon?.pricings.find((price) => price.capacities.includes('consumption')) | ||
| ?.price; | ||
|
|
||
| export const useData = (projectId: string) => { |
There was a problem hiding this comment.
As a general improvement, will be great to move some memoized functions out of the hook (SRP)
SimonChaumet
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developDescription
Related