Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-common): add 3AZ region and 1AZ chip #14672

Merged
merged 5 commits into from
Jan 14, 2025
Merged

feat(pci-common): add 3AZ region and 1AZ chip #14672

merged 5 commits into from
Jan 14, 2025

Conversation

SimonChaumet
Copy link
Contributor

@SimonChaumet SimonChaumet commented Dec 19, 2024 •
edited
Loading

Question Answer
Branch? maintenant/manager-pci-common-v0.x
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-2357 #TAPC-2413
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

For 3AZ we need to add 3AZ chip and feature flipped Region/1AZ chip.

Related

TODO : add pci v1 pull requests

@SimonChaumet SimonChaumet force-pushed the feat/pci-common-3az branch 5 times, most recently from dec4b7d to 78cb9c4 Compare December 20, 2024 15:28
@SimonChaumet SimonChaumet marked this pull request as ready for review December 20, 2024 16:17
@Tsiorifamonjena Tsiorifamonjena dismissed stale reviews from mhelhali-soufien and themself via 2bd2598 December 24, 2024 08:30
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 9, 2025
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jan 9, 2025
@SimonChaumet SimonChaumet force-pushed the feat/pci-common-3az branch 4 times, most recently from 16c419a to f826bd2 Compare January 9, 2025 17:13
@SimonChaumet
feat(pci-common): add 3AZ region and 1AZ chip
f6b4bb7 
ref: TAPC-2357,TAPC-2413

Signed-off-by: tsiorifamonjena <[email protected]>
Signed-off-by: Simon Chaumet <[email protected]>
Co-authored-by: Simon Chaumet <[email protected]>
frenautvh
frenautvh previously approved these changes Jan 10, 2025
View reviewed changes
fredericvilcot
fredericvilcot previously approved these changes Jan 13, 2025
View reviewed changes
lionel95200x
lionel95200x previously approved these changes Jan 14, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fredericvilcot fredericvilcot merged commit 455b619 into maintenance/manager-pci-common-v0.x Jan 14, 2025
14 checks passed
@fredericvilcot fredericvilcot deleted the feat/pci-common-3az branch January 14, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@Tsiorifamonjena Tsiorifamonjena Tsiorifamonjena approved these changes

@lionel95200x lionel95200x lionel95200x approved these changes

@sidlynx sidlynx sidlynx approved these changes

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SimonChaumet @sidlynx @lionel95200x @Tsiorifamonjena @frenautvh @fredericvilcot @mhelhali-soufien