feat(pci-object-storage): add container #14656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenautvh
requested review from
sidlynx,
kqesar,
aottr,
MaximeBajeux,
darsene and
seven-amid
and removed request for
a team
kqesar
approved these changes
Dec 18, 2024
seven-amid
reviewed
Dec 19, 2024
| token: string; | ||
| }; | ||
|
|
||
| export const getStorageAccess = async ({ |
There was a problem hiding this comment.
it's duplicated there is the same call in object.ts
export const getAccessToken = async (projectId: string): Promise<TAccess> => {
const { data } = await v6.post<TAccess>(
`/cloud/project/${projectId}/storage/access`,
);
return data;
};
There was a problem hiding this comment.
good catch i refactored this part
github-actions
bot
added
the
has conflicts
frenautvh
force-pushed
the
feat/pci-object-storage-container-creation
branch
from
5f25824 to
b41a736
Compare
github-actions
bot
removed
the
has conflicts
ref: DTCORE-2884 Signed-off-by: Florian Renaut <[email protected]>
frenautvh
force-pushed
the
feat/pci-object-storage-container-creation
branch
from
b41a736 to
4d86844
Compare
|
seven-amid
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
finalize container creation