Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(container): move the public cloud create project button #14635

Merged
merged 6 commits into from
Dec 19, 2024
Merged

feat(container): move the public cloud create project button #14635

merged 6 commits into from
Dec 19, 2024

Conversation

MaximeBajeux
Copy link
Contributor

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-16358
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@MaximeBajeux MaximeBajeux requested review from a team as code owners December 18, 2024 08:09
@github-actions github-actions bot added dependencies Pull requests that update a dependency file container feature New feature labels Dec 18, 2024
JacquesLarique
JacquesLarique previously approved these changes Dec 18, 2024
View reviewed changes
anooparveti
anooparveti requested changes Dec 19, 2024
View reviewed changes
yarn.lock Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see the need to include these changes as you're not modifying any package's version.

@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Dec 19, 2024
Maxime Bajeux added 5 commits December 19, 2024 09:27
feat(container): move the public cloud create project button
e2890e9 
ref: MANAGER-16358

Signed-off-by: Maxime Bajeux <[email protected]>
feat(container): fix artifactory link in yarn lock
a1c022b 
ref: MANAGER-16358

Signed-off-by: Maxime Bajeux <[email protected]>
feat(container): fix the tests
511f9c6 
ref: MANAGER-16358

Signed-off-by: Maxime Bajeux <[email protected]>
feat(container): fix yarn lock issue
59e2e47 
ref: MANAGER-16358

Signed-off-by: Maxime Bajeux <[email protected]>
feat(container): fix yarn lock issue
33fc55c 
ref: MANAGER-16358

Signed-off-by: Maxime Bajeux <[email protected]>
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 19, 2024
feat(container): fix yarn lock issue
954c560 
ref: MANAGER-16358

Signed-off-by: Maxime Bajeux <[email protected]>
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Dec 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oalkabouss oalkabouss changed the base branch from master to release/gcj-w52 December 19, 2024 16:09
@oalkabouss oalkabouss merged commit 7256c50 into release/gcj-w52 Dec 19, 2024
18 checks passed
@oalkabouss oalkabouss deleted the feat/MANAGER-16358 branch December 19, 2024 16:10
@oalkabouss oalkabouss mentioned this pull request Dec 20, 2024
Merged
9 tasks
oalkabouss pushed a commit that referenced this pull request Dec 23, 2024
@MaximeBajeux @oalkabouss
feat(container): move the public cloud create project button (#14635)
8b14f4e 
ref: MANAGER-16358

Signed-off-by: Maxime Bajeux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@anooparveti anooparveti anooparveti approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
container feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaximeBajeux @anooparveti @JacquesLarique @oalkabouss