fix(pci-object-storage): add container type step #14630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenautvh
requested review from
sidlynx,
kqesar,
anooparveti,
ghyenne and
darsene
and removed request for
a team
kqesar
approved these changes
Dec 17, 2024
sidlynx
approved these changes
Dec 17, 2024
| editContainerType, | ||
| } = useContainerCreationStore(); | ||
|
|
||
| const items = useMemo( |
There was a problem hiding this comment.
is useMemo necessary here cause the dependency is a constant
There was a problem hiding this comment.
yes good catch i removed it
ref: DTCORE-2884 Signed-off-by: Florian Renaut <[email protected]>
frenautvh
force-pushed
the
feat/pci-object-storage-container-type-step
branch
from
134cb2f to
5429cbc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add container type step