Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(pci-common): handle cjs files in dist folder #14614

Conversation

fredericvilcot
Copy link
Contributor

@fredericvilcot fredericvilcot commented Dec 17, 2024

Question Answer
Branch? master
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

This PR ensures that CJS import are well handled by the library

Related

@github-actions github-actions bot added the build Changes that affect the build system or external dependencie label Dec 17, 2024
@fredericvilcot fredericvilcot marked this pull request as ready for review December 17, 2024 10:05
@anooparveti anooparveti changed the base branch from master to release/pci-common-build-and-yarn-lock-fix December 18, 2024 06:59
@anooparveti anooparveti merged commit ebe8188 into release/pci-common-build-and-yarn-lock-fix Dec 18, 2024
23 checks passed
@anooparveti anooparveti deleted the build/pci-common-publish-cjs-dist branch December 18, 2024 06:59
@anooparveti anooparveti mentioned this pull request Dec 18, 2024
2 tasks
anooparveti pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencie
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants