Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web.domain): eligibility rules project #14608

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(web.domain): eligibility rules project #14608

wants to merge 6 commits into from

Conversation

ghyenne
Copy link
Contributor

@ghyenne ghyenne commented Dec 17, 2024 •
edited
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15265
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

It's the eligibility rules (domain owner)

Related

🎏 Translation:

  • CMT-20380

@ghyenne ghyenne requested a review from a team as a code owner December 17, 2024 08:29
@ghyenne ghyenne changed the title Feat/eligibility feat(web.domain): eligibility rules project Dec 17, 2024
Antony MARION and others added 2 commits December 31, 2024 11:25
@ghyenne
feat(web.domain): add contact management tab
b0e9fbe 
ref: MANAGER-15829

Signed-off-by: Guillaume Hyenne <[email protected]>
@ghyenne
feat(web.domain): form edit owner contact
0ab9974 
ref: MANAGER-15831

Signed-off-by: Guillaume Hyenne <[email protected]>
ghyenne added 2 commits January 2, 2025 15:16
@ghyenne
fix(web.domain): add tracking on contact management
9ebba08 
ref: MANAGER-15859

Signed-off-by: Guillaume Hyenne <[email protected]>
@ghyenne
fix(web.domain): change content domain holder description
96b6ecf 
ref: MANAGER-16585

Signed-off-by: Guillaume Hyenne <[email protected]>
ghyenne added 2 commits January 8, 2025 11:14
@ghyenne
fix(web.domain): update tracking for contact management
568652d 
ref: MANAGER-15859

Signed-off-by: Guillaume Hyenne <[email protected]>
@ghyenne
fix(web.domain): fix tracking page name for contact management
c107f48 
ref: MANAGER-15859

Signed-off-by: Guillaume Hyenne <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
3.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature quality check: ok translation required universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghyenne