Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/vrack services tests qpa #14596

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Feat/vrack services tests qpa #14596

merged 3 commits into from
Dec 16, 2024

Conversation

qpavy
Copy link
Contributor

@qpavy qpavy commented Dec 16, 2024

Question Answer
Branch? feat/vrack-services-tests
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #MANAGER-16104
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • [] Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

Related

Quentin Pavy added 3 commits December 13, 2024 13:08
feat(vrack-services): dissociate vrack it
4872b4f 
ref: MANAGER-16104

Signed-off-by: Quentin Pavy <[email protected]>
feat(vrack-services): confirm create vs it
086e32a 
ref: MANAGER-16104

Signed-off-by: Quentin Pavy <[email protected]>
feat(vrack-services): subnets it
fdb82d7 
ref: MANAGER-16104

Signed-off-by: Quentin Pavy <[email protected]>
@qpavy qpavy requested review from a team as code owners December 16, 2024 12:07
@qpavy qpavy requested review from kqesar, frenautvh, oalkabouss, ghyenne and sachinrameshn and removed request for a team December 16, 2024 12:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots
8.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@qpavy qpavy merged commit cba800d into feat/vrack-services-tests Dec 16, 2024
11 of 14 checks passed
@qpavy qpavy deleted the feat/vrack-services-tests-qpa branch December 16, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhelhali-soufien mhelhali-soufien mhelhali-soufien approved these changes

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qpavy @sachinrameshn @mhelhali-soufien