Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ldp): subscriptions list implementation #14583

Merged
merged 1 commit into from
Dec 19, 2024
Merged

feat(ldp): subscriptions list implementation #14583

merged 1 commit into from
Dec 19, 2024

Conversation

vovh
Copy link
Contributor

@vovh vovh commented Dec 16, 2024 •
edited
Loading

Question Answer
Branch? feat/logs-to-customer-module
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-15919
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@vovh vovh force-pushed the feat/MANAGER-15919 branch from b6e6e92 to 9666ec1 Compare December 16, 2024 08:38
@vovh vovh self-assigned this Dec 16, 2024
@vovh vovh force-pushed the feat/MANAGER-15919 branch 2 times, most recently from 7ebae77 to 3aa7cf4 Compare December 17, 2024 14:34
@rjamet-ovh rjamet-ovh force-pushed the feat/logs-to-customer-module branch from 6945713 to a77538a Compare December 18, 2024 08:13
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 18, 2024
@vovh vovh force-pushed the feat/MANAGER-15919 branch from 3aa7cf4 to c05814c Compare December 18, 2024 08:46
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 18, 2024
@vovh vovh force-pushed the feat/MANAGER-15919 branch 3 times, most recently from 1a57d49 to dd7b9cf Compare December 18, 2024 14:40
@vovh vovh marked this pull request as ready for review December 18, 2024 14:44
@vovh vovh requested review from a team as code owners December 18, 2024 14:44
@vovh vovh requested review from sidlynx, kqesar, qpavy, MaximeBajeux and darsene and removed request for a team December 18, 2024 14:44
@vovh vovh force-pushed the feat/MANAGER-15919 branch 2 times, most recently from 37c3548 to 12a77f8 Compare December 18, 2024 16:29
@vovh vovh force-pushed the feat/MANAGER-15919 branch 2 times, most recently from f169fb4 to 38c653b Compare December 19, 2024 12:55
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 19, 2024
@vovh vovh changed the base branch from feat/logs-to-customer-module to feat/MANAGER-15918 December 19, 2024 12:56
@vovh vovh force-pushed the feat/MANAGER-15919 branch from 38c653b to a118eb7 Compare December 19, 2024 12:57
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Dec 19, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 19, 2024
@vovh vovh changed the base branch from feat/MANAGER-15918 to feat/logs-to-customer-module December 19, 2024 13:05
@vovh vovh force-pushed the feat/MANAGER-15919 branch from a118eb7 to 8bbf220 Compare December 19, 2024 13:06
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 19, 2024
@vovh vovh force-pushed the feat/MANAGER-15919 branch from 8bbf220 to f878999 Compare December 19, 2024 13:50
@vovh vovh force-pushed the feat/MANAGER-15919 branch 2 times, most recently from 84e5462 to 39f3561 Compare December 19, 2024 14:50
@vovh
feat(ldp): subscriptions list implementation
cdc6e1b 
ref: MANAGER-15919

Signed-off-by: Vincent BONMARCHAND <[email protected]>
@vovh vovh force-pushed the feat/MANAGER-15919 branch from 39f3561 to cdc6e1b Compare December 19, 2024 14:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vovh vovh merged commit 44ad043 into feat/logs-to-customer-module Dec 19, 2024
14 checks passed
@vovh vovh deleted the feat/MANAGER-15919 branch December 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@pauldkn pauldkn pauldkn approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@vovh vovh

Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vovh @pauldkn @rjamet-ovh