Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/vrack services tests #14526

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Feat/vrack services tests #14526

merged 6 commits into from
Dec 17, 2024

Conversation

qpavy
Copy link
Contributor

@qpavy qpavy commented Dec 10, 2024

Question Answer
Branch? feat/vrack-services-ga
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #feat/MANAGER-16104
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • [ ] Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

Related

@qpavy qpavy requested review from a team as code owners December 10, 2024 16:48
@qpavy qpavy requested review from kqesar, frenautvh, MaximeBajeux, oalkabouss and ghyenne and removed request for a team December 10, 2024 16:48
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging translation required labels Dec 13, 2024
@qpavy qpavy force-pushed the feat/vrack-services-tests branch from b8b97ae to 1e47f32 Compare December 17, 2024 15:11
Quentin Pavy and others added 5 commits December 17, 2024 16:14
test(vrack-services): unit and integration testing
d75bf38 
ref: MANAGER-16104

Signed-off-by: Quentin Pavy <[email protected]>
@sachinrameshn
test(vrack-service): test case for delete vrackservice
bca8d35 
ref: MANAGER-16104

Signed-off-by: Sachin Ramesh <[email protected]>
test(vrack-services): add endpoints listing tests
0b70b7f 
ref: MANAGER-16104

Signed-off-by: soufien mhelhali <[email protected]>
feat(vrack-services): fix display title of edit modal
bd397ee 
ref: MANAGER-16092

Signed-off-by: soufien mhelhali <[email protected]>
test(vrack-services): listing and create endpoint it
7ade610 
ref: MANAGER-16104

Signed-off-by: Quentin Pavy <[email protected]>
@qpavy qpavy force-pushed the feat/vrack-services-tests branch from 1e47f32 to 7ade610 Compare December 17, 2024 15:14
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 17, 2024
@qpavy qpavy force-pushed the feat/vrack-services-tests branch 3 times, most recently from 2baae01 to 76854af Compare December 17, 2024 16:11
test(vrack-services): clean playwright files
ea8246b 
ref: MANAGER-16104

Signed-off-by: Quentin Pavy <[email protected]>
@qpavy qpavy force-pushed the feat/vrack-services-tests branch from 76854af to ea8246b Compare December 17, 2024 16:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@qpavy qpavy merged commit 7ff167e into feat/vrack-service-ga Dec 17, 2024
11 of 14 checks passed
@qpavy qpavy deleted the feat/vrack-services-tests branch December 17, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@chipp972 chipp972 chipp972 approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qpavy @chipp972 @sachinrameshn