feat(pci-databases-analytics) - refactor data table and add filtering #14524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feat/pci-db-analytics-rework-modals
to
release/public-cloud-w51
December 12, 2024 16:40
github-actions
bot
added
the
has conflicts
fredericvilcot
force-pushed
the
release/public-cloud-w51
branch
2 times, most recently
from
6b29873 to
afc8dfc
Compare
jperchoc
force-pushed
the
feat/data-table-sort-filter
branch
2 times, most recently
from
9a88aaf to
de328be
Compare
github-actions
bot
removed
the
has conflicts
jperchoc
changed the title
fredericvilcot
force-pushed
the
release/public-cloud-w51
branch
from
54e17af to
9da7f4f
Compare
github-actions
bot
added
has conflicts
fredericvilcot
force-pushed
the
release/public-cloud-w51
branch
3 times, most recently
from
58793cd to
0279f9d
Compare
jperchoc
force-pushed
the
feat/data-table-sort-filter
branch
from
878f3d5 to
4c1e100
Compare
github-actions
bot
added
translation required
and removed
universe-public-cloud
has conflicts
jperchoc
force-pushed
the
feat/data-table-sort-filter
branch
from
4c1e100 to
ccfdef7
Compare
Signed-off-by: Jonathan Perchoc <[email protected]>
jperchoc
force-pushed
the
feat/data-table-sort-filter
branch
from
ccfdef7 to
e3dff38
Compare
abullet33
previously approved these changes
Dec 30, 2024
tibs245
reviewed
Jan 9, 2025
Comment on lines
+3
to
+5
| export function DatatableAction({ children }: { children: ReactNode }) { | ||
| return <>{children || <></>}</>; | ||
| } |
There was a problem hiding this comment.
Suggested change
| export function DatatableAction({ children }: { children: ReactNode }) { | |
| return <>{children || <></>}</>; | |
| } | |
| export function DatatableAction({ children }: { children: ReactNode }) { | |
| return <>{children || undefined}</>; | |
| } |
jperchoc
added
quality check
universe-public-cloud
quality check: ok
and removed
quality check
translation required
labels
8 tasks
ref: DATATR-681 Signed-off-by: Jonathan Perchoc <[email protected]>
|
abullet33
approved these changes
Jan 16, 2025
The error is ignored as the error has nothing to do with the changes in PR and the error was resolved with #14959 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developDescription
Update data-table to add sorting and filtering
Related
The branch feat/mysql-query-statistics should be merged into this branch before proceeding to the release