Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pci-block-storage): use 730 hours for monthly price #14467

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix(pci-block-storage): use 730 hours for monthly price #14467

merged 1 commit into from
Jan 3, 2025

Conversation

SimonChaumet
Copy link
Contributor

@SimonChaumet SimonChaumet commented Dec 6, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #TAPC-2177
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

We have moved to 730h as a base for monthly price so we need to update in catalog

Related

@SimonChaumet SimonChaumet requested review from a team as code owners December 6, 2024 11:10
@github-actions github-actions bot added translation required bug Something isn't working labels Dec 6, 2024
@SimonChaumet SimonChaumet force-pushed the fix/block-use-730-base-price branch from b63e94b to 10f5886 Compare December 6, 2024 11:12
Tsiorifamonjena
Tsiorifamonjena previously approved these changes Dec 6, 2024
View reviewed changes
fredericvilcot
fredericvilcot previously approved these changes Dec 6, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 9, 2024
ThibaudCrespin
ThibaudCrespin previously approved these changes Dec 10, 2024
View reviewed changes
@SimonChaumet SimonChaumet force-pushed the fix/block-use-730-base-price branch from 10f5886 to 46a1bc0 Compare December 11, 2024 13:24
@github-actions github-actions bot added translation required and removed has conflicts Has conflicts to resolve before merging labels Dec 11, 2024
fredericvilcot
fredericvilcot previously approved these changes Dec 11, 2024
View reviewed changes
tristanwagner
tristanwagner previously approved these changes Dec 11, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 12, 2024
@SimonChaumet SimonChaumet force-pushed the fix/block-use-730-base-price branch from 46a1bc0 to 73a43d9 Compare December 12, 2024 16:49
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 12, 2024
tristanwagner
tristanwagner previously approved these changes Dec 13, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 16, 2024
@fredericvilcot fredericvilcot force-pushed the fix/block-use-730-base-price branch from 73a43d9 to 13117d8 Compare January 2, 2025 09:59
@github-actions github-actions bot added translation required and removed has conflicts Has conflicts to resolve before merging labels Jan 2, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anooparveti anooparveti changed the base branch from develop to release/public-cloud-w1 January 3, 2025 07:41
@anooparveti anooparveti merged commit e7ed140 into release/public-cloud-w1 Jan 3, 2025
16 of 17 checks passed
@anooparveti anooparveti deleted the fix/block-use-730-base-price branch January 3, 2025 07:41
@anooparveti anooparveti mentioned this pull request Jan 3, 2025
Merged
8 tasks
anooparveti pushed a commit that referenced this pull request Jan 7, 2025
@SimonChaumet @anooparveti
fix(pci-block-storage): use 730 hours for monthly price (#14467)
5ae1d0c 
ref: TAPC-2177

Signed-off-by: Simon Chaumet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@Eric-ciccotti Eric-ciccotti Eric-ciccotti approved these changes

@lionel95200x lionel95200x lionel95200x approved these changes

@acavalloni acavalloni acavalloni approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

@ThibaudCrespin ThibaudCrespin Awaiting requested review from ThibaudCrespin

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud Awaiting requested review from aboungnaseng-ovhcloud

@Tsiorifamonjena Tsiorifamonjena Awaiting requested review from Tsiorifamonjena

@tristanwagner tristanwagner Awaiting requested review from tristanwagner

Assignees
No one assigned
Labels
bug Something isn't working quality check: ok translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@SimonChaumet @acavalloni @lionel95200x @ThibaudCrespin @tristanwagner @Tsiorifamonjena @Eric-ciccotti @fredericvilcot @aboungnaseng-ovhcloud @anooparveti