fix(dedicated): fix Problem with timezone on graph displays #14430
Conversation
sepiropht
force-pushed
the
fix/UXCT-668
branch
2 times, most recently
from
aeb38fa to
b25c7f3
Compare
| after.setTime(this.dateTime); | ||
| after = new Date(this.dateTime); | ||
| after = new Date( | ||
| after.getTime() + after.getTimezoneOffset() * 4 * 60000, |
There was a problem hiding this comment.
I would recommend using date-fns to do this computation, it would be more understandable
You can also separate variables into constant
Personnaly I don't understand what 4 and 60 000 stand for
There was a problem hiding this comment.
When accessing the traffic dashboard via URL with a dateTime parameter,
alerts were often not visible due to timezone misalignment.
i just added proper timezone offset handling to ensure alerts appear within the
displayed time window.
There was a problem hiding this comment.
I still don't understand what this 4 stands for
There was a problem hiding this comment.
This part of code is outdate, if you look to the new version of code you could see a constant variable which explain what is this 4.
sepiropht
force-pushed
the
fix/UXCT-668
branch
from
b25c7f3 to
afe7fda
Compare
ref: UXCT-668 Signed-off-by: William Mbotta <[email protected]>
sepiropht
force-pushed
the
fix/UXCT-668
branch
from
afe7fda to
143ed45
Compare
|
ref: UXCT-668
masterOnly FR translations have been updated[n/a]Breaking change is mentioned in relevant commits[n/a]Description
Fix graph timezone
Related