Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(account): follow up demo kyc changes #14363

Merged
merged 3 commits into from
Dec 19, 2024
Merged

feat(account): follow up demo kyc changes #14363

merged 3 commits into from
Dec 19, 2024

Conversation

MaximeBajeux
Copy link
Contributor

ref: MANAGER-15565

Question Answer
Branch? master
Bug fix? no
New feature? no
Breaking change? no
Tickets MANAGER-15565
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@MaximeBajeux MaximeBajeux requested a review from a team as a code owner November 29, 2024 16:30
JacquesLarique
JacquesLarique previously approved these changes Dec 2, 2024
View reviewed changes
oalkabouss
oalkabouss previously approved these changes Dec 3, 2024
View reviewed changes
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-15565alt branch from 6c99abc to 1ced70a Compare December 4, 2024 12:27
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-15565alt branch from 1ced70a to 590ad34 Compare December 5, 2024 08:49
JacquesLarique
JacquesLarique previously approved these changes Dec 16, 2024
View reviewed changes
@oalkabouss oalkabouss changed the base branch from master to release/gcj-w52 December 19, 2024 16:04
Maxime Bajeux added 3 commits December 19, 2024 17:08
feat(account): follow up kyc india change requests
5bfaf35 
ref: MANAGER-155655

Signed-off-by: Maxime Bajeux <[email protected]>
feat(account): fix removed function issue
d8dcebf 
ref: MANAGER-15565

Signed-off-by: Maxime Bajeux <[email protected]>
fix(i18n): add missing translations [CDS 161]
9471ee9 
Signed-off-by: CDS Translator Agent <[email protected]>
@oalkabouss oalkabouss force-pushed the feat/MANAGER-15565alt branch from 5be23f0 to 9471ee9 Compare December 19, 2024 16:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oalkabouss oalkabouss merged commit 913d49c into release/gcj-w52 Dec 19, 2024
14 of 15 checks passed
@oalkabouss oalkabouss deleted the feat/MANAGER-15565alt branch December 19, 2024 16:43
@oalkabouss oalkabouss mentioned this pull request Dec 20, 2024
Merged
9 tasks
oalkabouss pushed a commit that referenced this pull request Dec 23, 2024
@MaximeBajeux @oalkabouss
feat(account): follow up demo kyc changes (#14363)
c1325a3 
ref: MANAGER-15565

Signed-off-by: Maxime Bajeux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@oalkabouss oalkabouss oalkabouss approved these changes

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximeBajeux @oalkabouss @JacquesLarique