Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kms): refacto delete modal #14351

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat(kms): refacto delete modal #14351

merged 1 commit into from
Dec 13, 2024

Conversation

chipp972
Copy link
Contributor

ref: MANAGER-15233

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15233
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@chipp972 chipp972 requested review from a team as code owners November 29, 2024 09:50
@github-actions github-actions bot added enabler feature New feature labels Nov 29, 2024
rjamet-ovh
rjamet-ovh previously approved these changes Dec 2, 2024
View reviewed changes
feat(kms): refacto delete modal
d7c2efd 
ref: MANAGER-15233

Signed-off-by: Nicolas Pierre-charles <[email protected]>
@chipp972 chipp972 dismissed stale reviews from rjamet-ovh and pauldkn via d7c2efd December 3, 2024 09:12
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tibs245 tibs245 changed the base branch from develop to release/enabler-hpc-w51 December 13, 2024 09:37
@tibs245 tibs245 mentioned this pull request Dec 13, 2024
Merged
7 tasks
@tibs245 tibs245 merged commit 2b655b9 into release/enabler-hpc-w51 Dec 13, 2024
17 checks passed
@tibs245 tibs245 deleted the feat/kms-15233 branch December 13, 2024 09:40
@tibs245 tibs245 mentioned this pull request Dec 17, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@ThibaudCrespin ThibaudCrespin ThibaudCrespin approved these changes

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

@pauldkn pauldkn Awaiting requested review from pauldkn

Assignees
No one assigned
Labels
enabler feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chipp972 @ThibaudCrespin @pauldkn @rjamet-ovh @tibs245