Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kms): remove new and beta tag from menu for KMS #14130

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat(kms): remove new and beta tag from menu for KMS #14130

merged 1 commit into from
Nov 21, 2024

Conversation

vovh
Copy link
Contributor

@vovh vovh commented Nov 15, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-15944
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@vovh
feat(kms): remove new and beta tag from menu for KMS
3bf43e7 
ref: MANAGER-15944

Signed-off-by: Vincent BONMARCHAND <[email protected]>
@vovh vovh self-assigned this Nov 15, 2024
@vovh vovh marked this pull request as ready for review November 15, 2024 15:36
@vovh vovh requested review from a team as code owners November 15, 2024 15:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tibs245
tibs245 previously approved these changes Nov 18, 2024
View reviewed changes
rjamet-ovh
rjamet-ovh previously approved these changes Nov 18, 2024
View reviewed changes
anooparveti
anooparveti previously approved these changes Nov 19, 2024
View reviewed changes
@JacquesLarique JacquesLarique changed the base branch from develop to release/gcj-w48 November 21, 2024 15:30
@JacquesLarique JacquesLarique changed the base branch from release/gcj-w48 to master November 21, 2024 16:05
@JacquesLarique JacquesLarique dismissed stale reviews from anooparveti, rjamet-ovh, and tibs245 November 21, 2024 16:05

The base branch was changed.

@JacquesLarique JacquesLarique changed the base branch from master to release/gcj-w48 November 21, 2024 16:05
@JacquesLarique JacquesLarique merged commit a0c7afc into release/gcj-w48 Nov 21, 2024
27 checks passed
@JacquesLarique JacquesLarique deleted the feat/MANAGER-15944 branch November 21, 2024 16:12
@JacquesLarique JacquesLarique mentioned this pull request Nov 21, 2024
Merged
2 tasks
JacquesLarique pushed a commit that referenced this pull request Nov 25, 2024
@vovh @JacquesLarique
feat(kms): remove new and beta tag from menu for KMS (#14130)
a6bd9fa 
ref: MANAGER-15944

Signed-off-by: Vincent BONMARCHAND <[email protected]>
ppprevost pushed a commit that referenced this pull request Nov 27, 2024
@vovh
feat(kms): remove new and beta tag from menu for KMS (#14130)
c1593d9 
ref: MANAGER-15944

Signed-off-by: Vincent BONMARCHAND <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@rjamet-ovh rjamet-ovh rjamet-ovh left review comments

@anooparveti anooparveti anooparveti left review comments

@tibs245 tibs245 tibs245 left review comments

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@vovh vovh

Labels
container feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vovh @tibs245 @SimonChaumet @anooparveti @JacquesLarique @rjamet-ovh