Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hycu): fix translation on edit name #14045

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix(hycu): fix translation on edit name #14045

merged 2 commits into from
Dec 13, 2024

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Nov 12, 2024 •
edited
Loading

ref: MANAGER-15973

Question Answer
Branch? feat/hycu
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-15973
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

🎏 Translation

  •  CMT-19564

@tibs245 tibs245 requested a review from a team as a code owner November 12, 2024 16:27
@tibs245 tibs245 requested review from antonymarion, oalkabouss and darsene and removed request for a team November 12, 2024 16:27
darsene
darsene previously approved these changes Nov 12, 2024
View reviewed changes
vovh
vovh previously approved these changes Nov 12, 2024
View reviewed changes
pauldkn
pauldkn previously approved these changes Nov 12, 2024
View reviewed changes
@ThibaudCrespin ThibaudCrespin requested review from a team as code owners November 13, 2024 15:57
@ThibaudCrespin ThibaudCrespin requested review from sidlynx and frenautvh and removed request for a team November 13, 2024 15:57
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 13, 2024
@tibs245 tibs245 force-pushed the feat/hycu branch 6 times, most recently from c492a03 to c65ba22 Compare November 19, 2024 13:14
Base automatically changed from feat/hycu to release/hycu November 19, 2024 14:09
Base automatically changed from release/hycu to master November 20, 2024 18:25
@anooparveti anooparveti dismissed stale reviews from pauldkn, vovh, and darsene November 20, 2024 18:25

The base branch was changed.

@tibs245 tibs245 changed the base branch from master to develop December 6, 2024 15:34
@tibs245 tibs245 force-pushed the feat/hycu-wording-edit-name branch from 0ffb5d8 to bd784fa Compare December 6, 2024 15:44
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed has conflicts Has conflicts to resolve before merging labels Dec 6, 2024
@tibs245
fix(hycu): fix translation on edit name
e8802f7 
ref: MANAGER-15973

Signed-off-by: Thibault Barske <[email protected]>

Signed-off-by: Thibault Barske <[email protected]>
@tibs245 tibs245 force-pushed the feat/hycu-wording-edit-name branch from bd784fa to e8802f7 Compare December 6, 2024 15:59
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Dec 6, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tibs245 tibs245 changed the base branch from develop to release/enabler-hpc-w51 December 13, 2024 09:41
@tibs245 tibs245 mentioned this pull request Dec 13, 2024
Merged
7 tasks
@tibs245 tibs245 merged commit f3086ea into release/enabler-hpc-w51 Dec 13, 2024
15 of 19 checks passed
@tibs245 tibs245 deleted the feat/hycu-wording-edit-name branch December 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@pauldkn pauldkn pauldkn approved these changes

@vovh vovh vovh left review comments

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature quality check: ok translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tibs245 @pauldkn @darsene @vovh