Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-load-balancer): add rename health monitor modal #13668

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat(pci-load-balancer): add rename health monitor modal #13668

merged 1 commit into from
Oct 21, 2024

Conversation

seven-amid
Copy link
Contributor

DTCORE-2771

  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@seven-amid seven-amid requested review from a team as code owners October 18, 2024 12:03
@seven-amid seven-amid requested review from kqesar, frenautvh, qpavy, darsene and mhelhali-soufien and removed request for a team October 18, 2024 12:03
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 21, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 21, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 21, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 21, 2024
Base automatically changed from feat/DTCORE-2655 to feat/pci-load-balancer October 21, 2024 14:59
@seven-amid seven-amid merged commit 4edf191 into feat/pci-load-balancer Oct 21, 2024
9 of 12 checks passed
@seven-amid seven-amid deleted the feat/DTCORE-2771 branch October 21, 2024 15:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@kqesar kqesar kqesar approved these changes

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seven-amid @kqesar @JacquesLarique