Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pci-load-balancer): add edit pool member name modal #13617

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Oct 16, 2024

ref: DTCORE-2661

Question Answer
Branch? feat/pci-load-balancer
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets DTCORE-2661
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@kqesar kqesar requested review from a team as code owners October 16, 2024 09:31
@kqesar kqesar requested review from sidlynx, frenautvh, antonymarion, MaximeBajeux and JacquesLarique and removed request for a team October 16, 2024 09:31
ref: DTCORE-2660
Signed-off-by: Yoann Fievez <[email protected]>
@kqesar kqesar merged commit 345cbcf into feat/pci-load-balancer Oct 18, 2024
10 of 12 checks passed
@kqesar kqesar deleted the feat/DTCORE-2661 branch October 18, 2024 08:21
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants