Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(procedures): rgpd add legal notice component #13611

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

oalkabouss
Copy link
Contributor

@oalkabouss oalkabouss commented Oct 16, 2024

ref: MANAGER-15376

Question Answer
Branch? feat/procedures-gdpr
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15376
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@oalkabouss oalkabouss requested review from a team as code owners October 16, 2024 07:16
@oalkabouss oalkabouss requested review from kqesar, seven-amid, qpavy, darsene and sachinrameshn and removed request for a team October 16, 2024 07:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be replace by a more generic version of the component, where you would pass just the translation function (once being t('rgpd') and the other t('2fa'))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the translation keys must be the same. or ${tkey}_legal_information

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
ref: MANAGER-15376

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
@oalkabouss oalkabouss merged commit 9d112ef into feat/procedures-gdpr Oct 17, 2024
10 of 12 checks passed
@oalkabouss oalkabouss deleted the feat/MANAGER-15376 branch October 17, 2024 08:41
Copy link

oalkabouss added a commit that referenced this pull request Oct 28, 2024
ref: MANAGER-15376

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss added a commit that referenced this pull request Nov 26, 2024
ref: MANAGER-15376

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss added a commit that referenced this pull request Dec 6, 2024
ref: MANAGER-15376

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants