Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pci-load-balancer): add rule form and create page #13582

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Oct 14, 2024

ref: DTCORE-2644

Question Answer
Branch? feat/pci-load-balancer
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets DTCORE-2644
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

ref: DTCORE-2644
Signed-off-by: Yoann Fievez <[email protected]>
@kqesar kqesar requested review from a team as code owners October 14, 2024 09:26
@kqesar kqesar requested review from sidlynx, frenautvh, qpavy, MaximeBajeux and mhelhali-soufien and removed request for a team October 14, 2024 09:26
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@@ -38,3 +38,16 @@ export const deleteL7Rule = async (
);
return data;
};

export const createRule = async (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createL7Rule, since other funcs has L7(deleteL7Rule,getL7Rules)

@kqesar kqesar merged commit 0ac6ce2 into feat/pci-load-balancer Oct 14, 2024
13 of 14 checks passed
@kqesar kqesar deleted the feat/DTCORE-2644 branch October 14, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants