Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pci kubernetes manage version update step tapc 329 800 #13271

Merged
merged 27 commits into from
Oct 10, 2024
Merged

Feat/pci kubernetes manage version update step tapc 329 800 #13271

merged 27 commits into from
Oct 10, 2024

Conversation

ppprevost
Copy link
Contributor

@ppprevost ppprevost commented Sep 25, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets TAPC-329 TAPC-800
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

On Step 2 of create a cluster --> I want now :
UI change for versions selection
Possiblity to manage Security Policy (new)

Related

@ppprevost ppprevost requested review from a team as code owners September 25, 2024 14:45
anooparveti
anooparveti previously approved these changes Sep 26, 2024
View reviewed changes
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_manage-version-update-step_tapc-329-800 branch from 5ea1a51 to 511fc60 Compare September 26, 2024 07:40
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_manage-version-update-step_tapc-329-800 branch from 511fc60 to 1b9ad02 Compare September 26, 2024 08:13
Pierre-Philippe added 13 commits October 2, 2024 14:43
feat(pci.kubernetes): fix PR review
47ef574 
ref: TAPC-329
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci.kubernetes): add space between doc link
91e975f 
ref: TAPC-329
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.kubernetes): add chip and text modification
da1f2c1 
ref: TAPC-800
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.kubernetes): add more style on version component
8f5d94e 
ref: TAPC-800
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.kubernetes): add test
516d3a7 
ref: TAPC-800
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.kubernetes): delete console log and use usemo to reverse
4562219 
ref: TAPC-800
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.kubernetes): delete useless comment
2867453 
ref: TAPC-800
Signed-off-by: Pierre-Philippe <[email protected]>
fix(pci.kubernetes): add chip
9e0908d 
ref: TAPC-329
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci-kubernetes): improve ts enum updatepolicy
9edc94c 
ref: TAPC-329
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci-kubernetes): fix test
d21634c 
ref: TAPC-329
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci-kubernetes): pr review
d0d791d 
ref: [TAPC-800, TAPC-329]
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci.kubernetes): delete uselesss comment
61c3c51 
ref: TAPC-800
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci.kubernetes): replace conditional view by a className hidden
2df8875 
ref: TAPC-329-800
Signed-off-by: Pierre-Philippe <[email protected]>
@antleblanc antleblanc dismissed stale reviews from frenautvh and fredericvilcot via b2028f2 October 4, 2024 12:36
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_manage-version-update-step_tapc-329-800 branch from b2028f2 to 2df8875 Compare October 4, 2024 12:53
fix(i18n): add missing translations [CDS 85]
dc4f2f1 
Signed-off-by: CDS Translator Agent <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@anooparveti anooparveti changed the base branch from develop to release/public-cloud-w42 October 10, 2024 14:16
@anooparveti anooparveti merged commit 9fc6199 into release/public-cloud-w42 Oct 10, 2024
14 of 17 checks passed
@anooparveti anooparveti deleted the feat/pci-kubernetes_manage-version-update-step_tapc-329-800 branch October 10, 2024 14:30
@anooparveti anooparveti mentioned this pull request Oct 10, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@acavalloni acavalloni acavalloni approved these changes

@frenautvh frenautvh frenautvh left review comments

@anooparveti anooparveti anooparveti left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ppprevost @acavalloni @SimonChaumet @anooparveti @frenautvh @fredericvilcot @ovh-ux-cds