Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated.vmware): custom nsx edges sizing #13140

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat(dedicated.vmware): custom nsx edges sizing #13140

wants to merge 4 commits into from

Conversation

darsene
Copy link
Contributor

@darsene darsene commented Sep 17, 2024 •
edited
Loading

ref: MANAGER-12763

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-15256
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

Rebase of #11068

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

@github-actions github-actions bot added the stale No activity since a long time label Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

This Pull Request is now closed due to inactivity.

@github-actions github-actions bot closed this Nov 2, 2024
@darsene darsene reopened this Nov 13, 2024
@github-actions github-actions bot removed the stale No activity since a long time label Nov 14, 2024
@ThibaudCrespin ThibaudCrespin marked this pull request as ready for review November 25, 2024 08:40
@ThibaudCrespin ThibaudCrespin requested a review from a team as a code owner November 25, 2024 08:40
@ThibaudCrespin ThibaudCrespin force-pushed the feat/custom-nsx-edges-sizing-bis branch from 4de162e to d55be83 Compare November 25, 2024 08:46
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 25, 2024
feat(dedicated.vmware): custom nsx edges sizing
9a55de7 
ref: MANAGER-12763

Signed-off-by: Amandine Dectot <[email protected]>
@ThibaudCrespin ThibaudCrespin force-pushed the feat/custom-nsx-edges-sizing-bis branch from d55be83 to 9a55de7 Compare November 27, 2024 08:37
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 27, 2024
Thibaud Crespin added 2 commits December 3, 2024 21:07
@ThibaudCrespin
feat(dedicated): reactivate nsx sizes in update page
829e68e 
ref: MANAGER-15424

Signed-off-by: Thibaud Crespin <[email protected]>
@ThibaudCrespin
feat(dedicated): display edge status in dashboard
74c5307 
ref: MANAGER-15423

Signed-off-by: Thibaud Crespin <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ThibaudCrespin
fix(dedicated): hide nsx edge tile on other products
25e7a70 
ref: MANAGER-16422

Signed-off-by: Thibaud Crespin <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibs245 tibs245 tibs245 left review comments

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature has conflicts Has conflicts to resolve before merging translation required universe-bare-metal-cloud universe-hosted-private-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darsene @tibs245