fix(pci-private-network): fixed re-render issue on language change #12641
Conversation
There was a problem hiding this comment.
General behavior is Manager refreshes when the user changes the language. What is the issue here?
There was a problem hiding this comment.
For react apps changing the language updates the UI without hard refreshing the whole manager ; the manager refreshes only for angularjs apps
There was a problem hiding this comment.
In my opinion, even if we re-render the UI when changing the language, it won't change anything on the region list, because changing language is different than changing subsidiary
There was a problem hiding this comment.
@qpavy the mapped region list is using translations (for macro region name) in an useEffect that's why i18n.language has been added to the useEffect dependencies list
There was a problem hiding this comment.
ok sorry for the misunderstanding
|
|
This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed. |
|
This Pull Request is now closed due to inactivity. |
oalkabouss
force-pushed
the
fix/PRB0041352
branch
from
0483a30 to
7c4f9ec
Compare
ref: PRB0041352 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
force-pushed
the
fix/PRB0041352
branch
from
7c4f9ec to
c21bfc8
Compare
|
ref: PRB0041352 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
ref: PRB0041352
masterOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related