Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dedicated.firewall): disable toggle button #10446

Conversation

Steffy29
Copy link
Contributor

@Steffy29 Steffy29 commented Dec 1, 2023

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #UXCT-512
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

disable toggle button if mitigation is on PERMANENT or FORCED status

Related

@Steffy29 Steffy29 self-assigned this Dec 1, 2023
@Steffy29 Steffy29 requested a review from a team as a code owner December 1, 2023 14:04
@Steffy29 Steffy29 requested review from dectotam, qpavy and ghyenne and removed request for a team December 1, 2023 14:04
@Steffy29 Steffy29 force-pushed the UXCT-512-edge-network-firewall-update branch 4 times, most recently from 71072b2 to 540e997 Compare December 1, 2023 15:25
@Steffy29 Steffy29 dismissed dectotam’s stale review December 5, 2023 11:11

your suggestion doesn't work.

@Steffy29 Steffy29 force-pushed the UXCT-512-edge-network-firewall-update branch from 540e997 to 15ac05e Compare December 5, 2023 11:12
@Steffy29 Steffy29 force-pushed the UXCT-512-edge-network-firewall-update branch from 15ac05e to a24861f Compare December 6, 2023 11:05
@Steffy29 Steffy29 requested a review from dectotam December 6, 2023 11:05
@Steffy29 Steffy29 force-pushed the feat/network-security-dashboard branch from 70dee84 to 9253589 Compare December 6, 2023 15:51
@Steffy29 Steffy29 requested review from a team as code owners December 6, 2023 15:51
@Steffy29 Steffy29 requested review from kqesar and frenautvh and removed request for a team December 6, 2023 15:51
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 6, 2023
@Steffy29 Steffy29 force-pushed the feat/network-security-dashboard branch from 9253589 to 4f2fad5 Compare December 6, 2023 17:29
@github-actions github-actions bot added translation required and removed has conflicts Has conflicts to resolve before merging labels Dec 6, 2023
@Steffy29 Steffy29 force-pushed the feat/network-security-dashboard branch from 4f2fad5 to c5e828e Compare December 6, 2023 17:56
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging labels Dec 6, 2023
@Steffy29 Steffy29 force-pushed the feat/network-security-dashboard branch 2 times, most recently from 9a9d087 to b396db4 Compare December 6, 2023 17:59
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging and removed has conflicts Has conflicts to resolve before merging labels Dec 6, 2023
@Steffy29 Steffy29 force-pushed the UXCT-512-edge-network-firewall-update branch 2 times, most recently from 80d8ce1 to 344dc7b Compare December 11, 2023 14:07
ref: UXCT-512

disable toggle button if mitigation is on PERMANENT or FORCED status

Signed-off-by: Stephanie Moallic <[email protected]>
@Steffy29 Steffy29 force-pushed the UXCT-512-edge-network-firewall-update branch from 344dc7b to 227e1ab Compare December 11, 2023 14:15
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Steffy29 Steffy29 merged commit 7cb9888 into feat/network-security-dashboard Dec 12, 2023
15 checks passed
@Steffy29 Steffy29 deleted the UXCT-512-edge-network-firewall-update branch December 12, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants