feat(dedicated.network-security): update call api for traffic #10407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steffy29
requested review from
dectotam,
darsene and
sachinrameshn
and removed request for
a team
qpavy
approved these changes
Nov 29, 2023
Steffy29
force-pushed
the
UXCT-510-traffic-chart-load-all-data
branch
from
bf77d1e to
787b5ef
Compare
darsene
reviewed
Dec 1, 2023
Comment on lines
+157
to
+159
| if (response.cursor.next) { | ||
| this.getAllTraffic(response.cursor.next, after, before, subnet); | ||
| } else { |
There was a problem hiding this comment.
API cursor is still KO ? You can't use pagination ?
There was a problem hiding this comment.
I use this API to retrieve data to display them into a graph component. So I need to retrieve all data to build the graph.
darsene
approved these changes
Dec 1, 2023
ref: UXCT-510 - update call API using pagination to load all traffic data for graph displayed Signed-off-by: Stephanie Moallic <[email protected]>
Steffy29
force-pushed
the
UXCT-510-traffic-chart-load-all-data
branch
from
787b5ef to
791149c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developBreaking change is mentioned in relevant commitsDescription
Related