Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for delayed governance #442

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

neokry
Copy link
Collaborator

@neokry neokry commented Feb 29, 2024

Description

Ensures DAO users cannot submit proposals when governance is delayed

Code review

  • Check activity tab for a delayed DAO and ensure countdown timer is shown
  • Check activity tab for a non delayed DAO and see normal proposals
  • try to navigate to /proposal/create and proposal/review for a delayed DAO and ensure a 403 is returned

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have done a self-review of my own code
  • Any new and existing tests pass locally with my changes
  • My changes generate no new warnings (lint warnings, console warnings, etc)

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nouns-builder ✅ Ready (Inspect) Visit Preview Feb 29, 2024 10:00pm
testnet-nouns-builder ✅ Ready (Inspect) Visit Preview Feb 29, 2024 10:00pm

@neokry neokry merged commit fe2abac into main Mar 1, 2024
2 of 3 checks passed
@neokry neokry deleted the add-proposal-disabled-check branch March 1, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants