Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs vote #384

Merged
merged 12 commits into from
Oct 17, 2023
Merged

Needs vote #384

merged 12 commits into from
Oct 17, 2023

Conversation

jordanlesich
Copy link
Collaborator

Description

image

Motivation & context

Encourage users to vote on proposals

Code review

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have done a self-review of my own code
  • Any new and existing tests pass locally with my changes
  • [ x My changes generate no new warnings (lint warnings, console warnings, etc)

@vercel
Copy link

vercel bot commented Oct 12, 2023

@jordanlesich is attempting to deploy a commit to the Nouns Builder Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nouns-builder ✅ Ready (Inspect) Visit Preview Oct 17, 2023 4:32am
testnet-nouns-builder ✅ Ready (Inspect) Visit Preview Oct 17, 2023 4:32am

@isaaczaak isaaczaak requested review from neokry and isaaczaak October 17, 2023 00:33
@jordanlesich jordanlesich merged commit fc3b901 into ourzora:main Oct 17, 2023
1 check failed
@jordanlesich jordanlesich deleted the needsVote branch October 17, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaczaak isaaczaak isaaczaak approved these changes

@neokry neokry neokry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanlesich @neokry @isaaczaak