ja: fix a bug that needed cast may not be done

If the cast source is a no weight reference vector and the cast target ja uses float32 weight, it should be casted. But it's not done.
otegami · Dec 17, 2024 · f2db1e3 · f2db1e3
1 parent 454ab05
commit f2db1e3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/store.c b/lib/store.c
@@ -5901,9 +5901,9 @@ grn_ja_cast_value_vector_fixed_uvector(grn_ctx *ctx,
       need_convert = true;
     }
     if (is_weight_float32) {
-      need_convert = value_is_weight_bfloat16;
+      need_convert = need_convert || value_is_weight_bfloat16;
     } else if (is_weight_bfloat16) {
-      need_convert = !value_is_weight_bfloat16;
+      need_convert = need_convert || !value_is_weight_bfloat16;
     } else {
       need_convert = true;
     }