Add mypy / pyright to a new CI for webapp tool #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurscchan
force-pushed
the
add-mypy-pyright-webapp
branch
2 times, most recently
from
0c2da44 to
0d1beef
Compare
arthurscchan
force-pushed
the
add-mypy-pyright-webapp
branch
from
0d1beef to
c932b9d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
arthurscchan
force-pushed
the
add-mypy-pyright-webapp
branch
from
10a494b to
d950194
Compare
arthurscchan
force-pushed
the
add-mypy-pyright-webapp
branch
from
0ff1ac9 to
8a5b6aa
Compare
arthurscchan
force-pushed
the
add-mypy-pyright-webapp
branch
from
0443d87 to
ebce47d
Compare
Signed-off-by: Arthur Chan <[email protected]>
arthurscchan
force-pushed
the
add-mypy-pyright-webapp
branch
from
ebce47d to
cdcd4a5
Compare
DavidKorczynski
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new CI for running mypy and pyright tool on the webapp tool. It could helps to detect possible typing and formatting problems.
This PR aims to resolve #1560.
As this PR enforce a new checking on webapp, the code needed to be fixed. Thus this PR should only be merged in after #1564 #1565 #1566 #1567 #1568 #1569 #1570 #1577 are all merged in. These PRs fix the preliminary set of problems and bugs when applying this new CI.