Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependency versions #191

Closed
wants to merge 1 commit into from
Closed

fix dependency versions #191

wants to merge 1 commit into from

Conversation

jadelkhoury
Copy link
Contributor

To remove the many warnings such as the ones below, update 2 dependencies.
as usual, if this is ok, I will make the change to the generator, and update all 4 servers

[WARNING] javax.inject.Inject scanned from multiple locations: jar:file:///C:/Users/JadEl-khoury/.m2/repository/javax/inject/javax.inject/1/javax.inject-1.jar!/javax/inject/Inject.class, jar:file:///C:/Users/JadEl-khoury/.m2/repository/org/glassfish/hk2/external/jakarta.inject/2.6.1/jakarta.inject-2.6.1.jar!/javax/inject/Inject.class

[WARNING] org.apache.taglibs.standard.tei.Util scanned from multiple locations: jar:file:///C:/Users/JadEl-khoury/.m2/repository/org/apache/taglibs/taglibs-standard-impl/1.2.5/taglibs-standard-impl-1.2.5.jar!/org/apache/taglibs/standard/tei/Util.class, jar:file:///C:/Users/JadEl-khoury/.m2/repository/javax/servlet/jstl/1.2/jstl-1.2.jar!/org/apache/taglibs/standard/tei/Util.class

@jadelkhoury jadelkhoury marked this pull request as draft December 4, 2023 23:11
@jadelkhoury
Copy link
Contributor Author

I marked as Draft, because we should not merge this PR. I will do it through LyoGeneration.

@Jad-el-khoury
Copy link
Member

@berezovskyi What do you think of this PR?

@berezovskyi
Copy link
Member

Looks good! Couldn't find the LyoDesigner sister PR.

@Jad-el-khoury
Copy link
Member

In this case, I wanted to get to an approved version before I implement in Lynx (I was guessing there might be some changes this time :-))

@jadelkhoury
Copy link
Contributor Author

Won't merge. will push same changes through generation from LyoGen

@jadelkhoury jadelkhoury closed this Dec 7, 2023
@berezovskyi berezovskyi deleted the fixdependencies branch March 19, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants