Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua]Fix clbk_visualdestroyed not being called #511

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

TheGondos
Copy link
Contributor

Fix lame typo in ScriptVessel.cpp preventing clbk_visualdestroyed from being called.

@TheGondos
Copy link
Contributor Author

TheGondos commented Nov 17, 2024

WTF? A C++ include statement is now required in D3D9Util.cpp? And after adding it there is another error for a missing XRSound.h, only in the 64bit build, mind you...
Can anybody restart the build to see if it's a random issue? Maybe there is a dependency missing somewhere?
Edit: added XRSound_assets dependency to the LuaInterpreter since it's the target that deploys the XRSound.h file

@Xyon Xyon merged commit 283479a into orbitersim:main Nov 21, 2024
2 checks passed
@GLS-SSV
Copy link
Contributor

GLS-SSV commented Nov 22, 2024

I'm sorry to dig the standards thing up again, but the line
#include
makes Orbiter leave C++17 behind...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants